perny/hudkit
1
3
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat/translation #4

Closed
tropicalshadow wants to merge 5 commits from tropicalshadow/hudkit:feat/translation into main
pull from: tropicalshadow/hudkit:feat/translation
merge into: perny:main
Conversation 4 Commits 5 Files changed 4 +96 -15
tropicalshadow commented 2026-01-19 02:19:42 +02:00
Contributor
Copy link
  • audience wrapper (WeakRef) for manual setting of locale (🤔maybe not needed but potental)
  • pass Pointered (new audience wrapper) to MiniMessage (Lang support)
  • make huds a WeakHashMap, don't keep hold of audiences :)
- audience wrapper (WeakRef) for manual setting of locale (🤔maybe not needed but potental) - pass Pointered (new audience wrapper) to MiniMessage (Lang support) - make huds a WeakHashMap, don't keep hold of audiences :)
tropicalshadow commented 2026-01-30 04:35:43 +02:00
Author
Contributor
Copy link

👉 😀 👈

👉 😀 👈
perny commented 2026-01-30 17:55:20 +02:00
Owner
Copy link

I'll be back to home on Sunday, and I can continue hudkit development then. :)

I'll be back to home on Sunday, and I can continue hudkit development then. :)
❤️ 1
perny requested changes 2026-01-31 19:41:02 +02:00
perny left a comment
Copy link

Looks pretty solid!

Looks pretty solid!
api/src/main/kotlin/HudAudience.kt
@ -0,0 +24,4 @@
fun getUsername(): String? = audience.get()?.get<String>(Identity.NAME)?.orElse(null)
fun getDisplayName(): Component? = audience.get()?.get<Component>(Identity.DISPLAY_NAME)?.orElse(null)
fun getLocale(): Locale = locale?: audience.get()?.get<Locale>(Identity.LOCALE)?.orElse(Locale.getDefault())?: Locale.getDefault()
perny commented 2026-01-31 19:40:37 +02:00
Owner
Copy link

Won't compile, there's a JVM signature clash.

The following declarations have the same JVM signature (getLocale()Ljava/util/Locale;):
fun (): Locale? defined in net.hudkit.api.HudAudience
fun getLocale(): Locale defined in net.hudkit.api.HudAudience

The var locale: Locale? property auto-generates a getter that conflicts with the explicit fun getLocale(): Locale method.

Won't compile, there's a JVM signature clash. The following declarations have the same JVM signature (getLocale()Ljava/util/Locale;): fun <get-locale>(): Locale? defined in net.hudkit.api.HudAudience fun getLocale(): Locale defined in net.hudkit.api.HudAudience The `var locale: Locale?` property auto-generates a getter that conflicts with the explicit `fun getLocale(): Locale` method.
tropicalshadow commented 2026-02-03 00:28:53 +02:00
Author
Contributor
Copy link

should be resolved thanks to Claw

should be resolved thanks to Claw
tropicalshadow marked this conversation as resolved 
Add @JvmName annotations to the locale property getter/setter to avoid
conflict with the explicit getLocale() method that provides fallback logic.
Reviewed-on: tropicalshadow/hudkit#1
perny commented 2026-05-06 12:14:29 +03:00
Owner
Copy link

Will be closed as the architecture is fundamentally different now.

Will be closed as the architecture is fundamentally different now.
perny closed this pull request 2026-05-06 12:14:31 +03:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
perny
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
perny/hudkit!4
No description provided.