fix nil pointer when no server provided (or miss-spelled) #1

tropicalshadow · 2026-01-18T18:07:07+02:00

tropicalshadow commented

2026-01-18 18:07:07 +02:00

return error if the server is default
updated .gitignore to exclude runtime & intellij files from git

- return error if the server is default - updated .gitignore to exclude runtime & intellij files from git

tropicalshadow added 2 commits

2026-01-18 18:07:07 +02:00

chore: update .gitignore to ignore runtime & intellij files a508bd7eeb

fix: return error if server config isn't found inside toml c5af943258

perny requested changes

2026-01-18 19:21:33 +02:00

Dismissed

pkg/plugstep/config/load.go

					
				@ -15,1 +17,4 @@

					if config.Server == (ServerConfig{}) {

						log.Error("no server configuration found in config file")

						return nil, errors.New("no server configuration found in config file")

We use fmt.Errorf for all returned errors, not errors.New

We use `fmt.Errorf` for all returned errors, not `errors.New`

I am still new to the ways of go, fmt.Errorf has been put into action, I have also removed the prior error log due to the returning error being logged anyways

tropicalshadow marked this conversation as resolved

tropicalshadow added 1 commit

2026-01-18 21:05:20 +02:00

fix: improve error message for missing server configuration 2b0dc44cd8

tropicalshadow requested review from perny

2026-01-18 21:06:19 +02:00

perny approved these changes

2026-01-18 23:53:22 +02:00

perny left a comment

LGTM

👍 1

perny merged commit 99f5142abf into main