mcce/website
2
0
Fork 1
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add the Matrix space next to Discord server link at the footer and header #1

Merged
perny merged 1 commit from oliik/website:master into master 2026-09-03 23:19:00 +03:00
Conversation 6 Commits 1 Files changed 6 +34 -4
oliik commented 2026-08-26 21:31:44 +03:00
Contributor
Copy link

Had to also add an assets: icon handler for the matrix icon, beacuse the matrix icon isnt on any icon repositories in this repo (svg of the icon in /src/assets).

Had to also add an assets: icon handler for the matrix icon, beacuse the matrix icon isnt on any icon repositories in this repo (svg of the icon in /src/assets).
Had to also add an assets: icon handler for the matrix icon, beacuse the matrix icon isnt on any icon repositories in this repo (svg of the icon in /src/assets).
perny requested changes 2026-08-26 22:03:10 +03:00
src/assets/matrix-icon.svg Outdated
@ -0,0 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
perny commented 2026-08-26 21:55:28 +03:00
Owner
Copy link

A vector icon simply doesn't look good next to the pixelated ones, have you seen if anyone's made a pixelated Matrix icon? If not, would you want to draw one? I can too, if you'd like :)
image

A vector icon simply doesn't look good next to the pixelated ones, have you seen if anyone's made a pixelated Matrix icon? If not, would you want to draw one? I can too, if you'd like :) ![image](/attachments/920278aa-fa50-4d67-a5cf-508e5e866750)
image.png
25 KiB
perny marked this conversation as resolved
src/assets/matrix-icon.svg Outdated
@ -0,0 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Generator: Adobe Illustrator 19.1.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) -->
perny commented 2026-08-26 22:00:36 +03:00
Owner
Copy link

Also, by using this logo, we must follow the Matrix.org Foundation's trademark policy, which should be an addition to the colophon.

Also, by using this logo, we must follow the Matrix.org Foundation's trademark policy, which should be an addition to the colophon.
perny commented 2026-08-28 23:35:35 +03:00
Owner
Copy link

@oliik This still has to be solved.

@oliik This still has to be solved.
src/components/Icon.astro Outdated
@ -29,0 +40,4 @@
);
}
viewBox = raw.match(/viewBox=["']([^"']+)["']/i)?.[1] ?? viewBox;
perny commented 2026-08-26 22:02:51 +03:00
Owner
Copy link

Since we own the source SVG (i.e. it's committed here), could we not just do this modification in the source instead of a wonky regex?

Since we own the source SVG (i.e. it's committed here), could we not just do this modification in the source instead of a wonky regex?
perny marked this conversation as resolved
perny commented 2026-08-26 22:09:22 +03:00
Owner
Copy link

also, the PGP on your commit does not verify, if you could, fix that and force push.

also, the PGP on your commit does not verify, if you could, fix that and force push.
perny reviewed 2026-08-26 22:16:03 +03:00
src/components/Header.astro Outdated
@ -71,1 +71,4 @@
</a>
<a class="icon-only" href={LINKS.matrix} title="Matrix">
<Icon name="assets:matrix-icon" size="1rem" />
<span class="visually-hidden">matrix</span>
perny commented 2026-08-26 22:14:19 +03:00
Owner
Copy link

This should be Matrix, as it's shown in the mobile nav.

This should be `Matrix`, as it's shown in the mobile nav.
perny marked this conversation as resolved
src/components/Header.astro Outdated
@ -146,2 +150,4 @@
}
nav a.icon-only + a.icon-only {
margin-left: 0.5rem;
perny commented 2026-08-26 22:15:57 +03:00
Owner
Copy link

image what is the purpose of this style? it makes the icon not align on the mobile nav.

![image](/attachments/dce9ddc7-ae48-46f6-9b64-20bd9be78228) what is the purpose of this style? it makes the icon not align on the mobile nav.
image.png
3.7 KiB
perny marked this conversation as resolved
oliik commented 2026-08-27 17:29:08 +03:00
Author
Contributor
Copy link

Fixed these issues, and for the matrix logo i got sent an pixel one that i changed to

Fixed these issues, and for the matrix logo i got sent an pixel one that i changed to
perny reviewed 2026-08-28 23:38:39 +03:00
perny left a comment
Copy link

Just the licensing issue mentioned in the first review, this margin and then if you could fix the commit metadata issue. Your commit doesn't have to be signed at all, so you can just make it without any PGP data.

Just the licensing issue mentioned in the first review, this margin and then if you could fix the commit metadata issue. Your commit doesn't have to be signed at all, so you can just make it without any PGP data.
src/components/Header.astro Outdated
@ -69,6 +69,10 @@ const path = Astro.url.pathname;
<Icon name="pixel:discord" size="1.2rem" />
<span class="visually-hidden">Discord</span>
</a>
<a class="icon-only" href={LINKS.matrix} title="Matrix">
perny commented 2026-08-28 23:37:48 +03:00
Owner
Copy link

This needs more horizontal margin next to the Discord icon on desktop
image

This needs more horizontal margin next to the Discord icon on desktop ![image](/attachments/59ff205d-377a-44fa-bc8a-4bc1ee9ef6de)
image.png
59 KiB
oliik commented 2026-08-29 13:58:24 +03:00
Author
Contributor
Copy link

Fixed the licencing issue, added the margin and i disabled signing, the signing issue seems to be on the forgejo side as on my side git says the signature is correct

Fixed the licencing issue, added the margin and i disabled signing, the signing issue seems to be on the forgejo side as on my side git says the signature is correct
perny merged commit 7e294f8862 into master 2026-09-03 23:19:00 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
perny
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mcce/website!1
No description provided.